Skip to content

Small revisions to the global API migration guide #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

skirtles-code
Copy link
Contributor

This PR includes several small changes to global-api.md in the migration guide, including:

  • Remove the Vue. prefix in examples that don't really need it. The difference between the ESM and CDN builds is covered near the top so there's no need to include that prefix in the examples that follow.
  • Adjust the indentation (lines 31-42) so the example is indented to match the list.
  • Change the word current to Vue 2. I assume the wording was copied from the RFC.

I think the other tweaks are probably self-explanatory but let me know if anything isn't clear.

I did want to change the Foo and Bar to more meaningful names but I don't understand that example well enough to come up with something suitable.

@NataliaTepluhina NataliaTepluhina merged commit e2c8359 into vuejs:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants